FIX: Control Schemes dropdown keeps showing a deleted scheme name after the last scheme is removed [UUM-141563] - #2463
Merged
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2463 +/- ##
========================================
Coverage 78.95% 78.95%
========================================
Files 767 767
Lines 140780 140796 +16
========================================
+ Hits 111153 111168 +15
- Misses 29627 29628 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ritamerkl
approved these changes
Aug 5, 2026
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed the Control Schemes dropdown in the Input Actions editor continuing to display a deleted scheme's name after the last control scheme was removed, instead of resetting to "No Control Schemes" until the asset was saved or the editor reopened [UUM-141563](https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-141563) |
Collaborator
There was a problem hiding this comment.
Full stop missing, otherwise looks good.
…er the last scheme is removed [UUM-141563] After deleting the only control scheme in the Input Actions editor, the Control Schemes toolbar dropdown kept displaying the just-deleted scheme's name until the asset was saved or the editor reopened. InputActionsEditorView.SetUpControlSchemesMenu(ViewState) only assigned m_ControlSchemesToolbar.text inside the `viewState.controlSchemes.Any()` branch, so when the collection became empty the toolbar retained its stale text. Add an else branch that resets the text to the "No Control Schemes" default seeded by InputActionsEditor.uxml. Jira: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-141563
Pauliusd01
force-pushed
the
fix/uum-141563-control-schemes-toolbar-text
branch
from
August 5, 2026 09:08
a2537bf to
7dce902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
This pull request was generated automatically. Please review carefully before merging.
InputActionsEditorView.SetUpControlSchemesMenu(ViewState viewState)assignedm_ControlSchemesToolbar.textonly inside theviewState.controlSchemes.Any()branch. When the last control scheme was deleted and the collection became empty, that branch was skipped, so the Control Schemes dropdown in the Input Actions editor kept displaying the just-deleted scheme's name instead of the default until the asset was saved or the editor reopened.This adds an
elsebranch that resetsm_ControlSchemesToolbar.textto"No Control Schemes", the value the toolbar is seeded with inInputActionsEditor.uxml, so the empty state renders correctly on the same redraw that removes the scheme.Testing status & QA
ToolbarMenudropdown, which the editor tests currently cannot drive (the one sibling test exercising this toolbar is[Ignore]d for that reason).Overall Product Risks
Comments to reviewers
N/A
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.